[FFmpeg-devel] [PATCH][7/8] Add VA API accelerated H.264 decoding (take 4)
Mon Feb 9 17:23:53 CET 2009
On Mon, Feb 09, 2009 at 04:59:13PM +0100, Gwenole Beauchesne wrote:
> On Mon, 9 Feb 2009, Michael Niedermayer wrote:
> > This isnt fair but it is effective and practical, if you have a better
> > suggestion, its welcome of course, but not factorizing code or commiting
> > suboptimal code is not ok.
> Commit and have a third couple of eyes working on leveraging, e.g. through
> a SoC. ;-)
> I think I will need to find a kind Carl-Heugen clone.
Sometimes kind spirits appear, but don't count on it.
> You know, I don't have infinite time, what's the real benefit of
> overhauling the current implementation that works?
Landing it in FFmpeg?
> Your current approach tends to discourage people. I now better understand
> why some other people told me off-list they have stopped trying
> upstream'ing patches and kept them lying around separately, somewhere...
There are always legends of such things, but in practice most people
do follow up on patches...
> At the very least, you should have commented on the real implementation
> earlier/beforehand, not many weeks after commenting on pure *cosmetics*.
> That's a terrible waste of time, and totally suboptimal process. IOW,
> cosmetics are the last things to care about in a process, especially if
> those are things that could be done through an automated tool.
I don't think anybody really realized the issues before.
More information about the ffmpeg-devel