[FFmpeg-devel] [PATCH] fix playback of partial DV files

Reimar Döffinger Reimar.Doeffinger
Mon Feb 9 22:48:20 CET 2009

On Mon, Feb 09, 2009 at 01:24:23PM -0800, Baptiste Coudurier wrote:
> You could avoid the seek by filling c->buf directly, would this be hard ?

No, just didn't see it. I attached an updated version, I admit I did not
test it, compilation is too slow on this PC.

> Do you see a need in changing the test in the while loop like in the
> probe function ?

I don't think it matters much.
But if you use
(state & 0xffffff7f) != 0x1f07003f
you can use just "unsigned" instead of uint32_t.
A tiny bit faster and smaller code (since many architectures might be
able to use instructions with immediates) might be
uint32_t state;
if ((state | 0x80) != 0x1f0700bf)

I do think it is preferable to use the same variant everywhere.

Reimar D?ffinger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvsearch.diff
Type: text/x-diff
Size: 1126 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090209/7c793337/attachment.diff>

More information about the ffmpeg-devel mailing list