[FFmpeg-devel] [PATCH] libavcodec/lpc.c: Fix warning about uninitialized variable
Tue Feb 10 10:08:22 CET 2009
On Tue, 2009-02-10 at 14:29 +0530, Jai Menon wrote:
> On Tue, Feb 10, 2009 at 2:14 PM, Jai Menon <jmenon86 at gmail.com> wrote:
> > On Tue, Feb 10, 2009 at 2:08 PM, Patrik Kullman <patrik at yes.nu> wrote:
> >> If use_lpc < 1 and max_order > 0, weight would be uninitialized.
> > since a use_lpc of 0 was never intended, maybe an assert could be used....
> to clarify, i meant an assert on use_lpc == 0
Well, a negative value in use_lpc wouldn't initialize weight either.
Are negative values intended?
If so, weight still needs to be initalized.
If not, second patch should be ok.
More information about the ffmpeg-devel