[FFmpeg-devel] [PATCH] use av_mallocz() in vorbis_comment()

Justin Ruggles justin.ruggles
Wed Feb 11 04:42:57 CET 2009


Hi,

This patch avoids allocating memory on the stack based on decoded stream
values which can be up to 32-bit.  Mans has pointed out that the current
version is not a security risk, it would just crash with SIGSEGV for
really large metadata.  This patch skips the single metadata tag if
allocation fails and continues try to the next tag.

Thanks,
Justin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbiscomment_av_mallocz.diff
Type: text/x-diff
Size: 1179 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090210/15b9e3e3/attachment.diff>



More information about the ffmpeg-devel mailing list