[FFmpeg-devel] [PATCH] Workaround Mac-OS x86_64 dynamic loader bug for Yasm generated code

Art Clarke aclarke
Wed Feb 11 23:56:28 CET 2009

>> --- libavcodec/x86/fft_mmx.asm        (revision 16989)
>> +++ libavcodec/x86/fft_mmx.asm        (working copy)
>> @@ -446,8 +446,16 @@
>>  %endrep
>>  %undef n
>> +%ifidn __OUTPUT_FORMAT__,macho64
>> +; Putting this section in .text on x86_64 darwin causes problems
>> +section .rodata
>> +%endif
>>  align 8
>>  dispatch_tab%3%2: pointer list_of_fft
>> +%ifidn __OUTPUT_FORMAT__,macho64
>> +; Set section back to .text
>> +section .text
>> +%endif
> What about this?
> Diego

I'd still love someone to review it and either reject with feedback or
commit; the gist of the feedback so far is that it may or may not be
applicable to other systems in addition to macho64, and there is some
disagreement about that.

But every reviewer seems to agree it fixes the intended problem; macho64.

For now, we've moved on and just disabled yasm completely on os-x
x86_64 because of this (Thanks to Mans' committed --disable-yasm
switch), but it'd be great to have yasm code back in the shared x86_64

- Art

xu?ggle (z?' gl) v. To freely encode, decode, and experience audio and video.

Use Xuggle to get the power of FFMPEG in Java.

More information about the ffmpeg-devel mailing list