[FFmpeg-devel] [PATCH] libavcodec/lpc.c: Fix warning about uninitialized variable

Jai Menon jmenon86
Thu Feb 12 06:42:33 CET 2009


On Thu, Feb 12, 2009 at 8:24 AM, Justin Ruggles
<justin.ruggles at gmail.com> wrote:
> Patrik Kullman wrote:
>>> These 3 changes should probably be in 3 separate commits.
>>>
>>> -Justin
>>
>> How about this?
>>
>> ffmpeg-lpc-document_use_lpc.patch:
>> Document explanation on how use_lpc is set
>>
>> ffmpeg-lpc_assert_use_lpc.patch:
>> Assert that ff_lpc_calc_coefs() is called with a valid LPC method.
>>
>> ffmpeg-lpc-uninit-weight.patch:
>> Based on ffmpeg-lpc_assert_use_lpc.patch, remove false positive
>> compilation warning about weight being uninitialized.
>
> All 3 patches look good to me.
>
> BTW, should I add myself as lpc.[ch] maintainer since it was split off
> from a file I already maintain?

Yes you probably should ;) . Sorry for not doing that during the split itself

> -Justin

-- 
Regards,

Jai




More information about the ffmpeg-devel mailing list