[FFmpeg-devel] [PATCH] libavfilter-soc: make scale algorithm configurable
Fri Feb 13 03:10:26 CET 2009
On Fri, Feb 13, 2009 at 02:13:38AM +0100, Stefano Sabatini wrote:
> On date Monday 2009-02-09 19:45:06 +0100, Michael Niedermayer encoded:
> > On Sun, Feb 08, 2009 at 11:45:34PM +0100, Stefano Sabatini wrote:
> > > On date Sunday 2009-02-08 03:01:37 +0100, Michael Niedermayer encoded:
> > > > On Sat, Feb 07, 2009 at 08:30:01PM +0100, Stefano Sabatini wrote:
> > > > > But I agree on the limitation of the libswscale API, ideally maybe we
> > > > > should be able to pass in the opaque a pointer to an already allocated
> > > > > swscale context already containing sws flags + vectors + whatever,
> > > > > which we could allocate with something like:
> > > >
> > > > am i missing something that make this opaque stuff needed, compared to
> > > > simply passing char* ?
> > >
> > > I'd like to avoid to convert the sws_flags of the AVFilterGraph to a
> > > string when creating and inserting the scale filter.
> > >
> > > The scale filter should be able to accept in input the sws context
> > > parameters from the args string.
> > >
> > > But using the args interface for passing the flags from the
> > > AVFilterGraph sws_flags to the scale filter is quite awkward, and
> > > involves doing snprintf in the
> > > query_formats/avfilter_graph_config_formats() code.
> > i think i prefer if args is used instead of doing funny things with
> > opaque dummy contexts
> New patch, but I still would prefer a solution using somehow a
> SwsContext in the AVFilterGraph.
i suspect we see this from a differnt point of view ...
iam scared of passing 5 filter private contexts around randomly in
now its just sws but that might change ...
and a string is much clearer in that case ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel