[FFmpeg-devel] XVMC Deathmatch

Ivan Kalvachev ikalvachev
Sat Feb 14 17:47:43 CET 2009

On 2/14/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
> The review is below
> (due to 1-10 points)
> -10 points (for each case)
> breaking compilation, regtests or the code in question if the other
> gladiator notices the breakage and post a note to ffmpeg-cvslog
> -10 points (for each case)
> obstructing the others work or not spliting changes half sanely
> [...]
>>#include <X11/Xlib.h>
>>#include <X11/Xutil.h>
>>#include <X11/Xatom.h>
>>#include <X11/extensions/Xv.h>
>>#include <X11/extensions/Xvlib.h>
>>#include <X11/extensions/XvMClib.h>
> 10 Points:
> Get rid of these includes so that the header can be included
> unconditionally that is without requireing X11 headers

This can't be done.
Current header requirement demands including the headers needed in
the given file.
This means that the last XvMClib.h is needed for this header
and it is X11.

The only other way is to make pointer to structures into void *.
I don't like it.

More information about the ffmpeg-devel mailing list