[FFmpeg-devel] [PATCH] Document av_[io]format_next() functions

Michael Niedermayer michaelni
Sat Feb 14 22:34:44 CET 2009


On Sat, Feb 14, 2009 at 10:22:40PM +0100, Stefano Sabatini wrote:
> On date Saturday 2009-02-14 22:10:52 +0100, Michael Niedermayer encoded:
> > On Sat, Feb 14, 2009 at 08:14:04PM +0100, Stefano Sabatini wrote:
> > > On date Saturday 2009-02-14 18:35:46 +0000, Robert Swain encoded:
> > > > 2009/2/14 Michael Niedermayer <michaelni at gmx.at>:
> > > > > On Sat, Feb 14, 2009 at 06:30:32PM +0100, Stefano Sabatini wrote:
> > > > >> Index: libavformat/avformat.h
> > > > >> ===================================================================
> > > > >> --- libavformat/avformat.h    (revision 17180)
> > > > >> +++ libavformat/avformat.h    (working copy)
> > > > >> @@ -687,7 +687,18 @@
> > > > >>  extern AVOutputFormat *first_oformat;
> > > > >>  #endif
> > > > >>
> > > > >> +/**
> > > > >> + * If \p f is NULL returns the first registered input format,
> > > > >
> > > > >> + * if \p is non-NULL returns the registered input format next to \p f,
> > > > >
> > > > > next to ?
> > > > > iam no native but this sounds fishy in this context
> > > > > "id say the successor of" or the "one after" or "the next after"
> > > > > "the one following "
> > > > 
> > > > "Next to" merely means adjacent. It could be before or after.
> > > 
> > > So what about s/next to/next after/?
> > > 
> > > Regards.
> > > -- 
> > > FFmpeg = Frenzy and Fast Mastering Powered Ecumenical Guru
> > 
> > > Index: libavformat/avformat.h
> > > ===================================================================
> > > --- libavformat/avformat.h	(revision 17180)
> > > +++ libavformat/avformat.h	(working copy)
> > > @@ -687,7 +687,18 @@
> > >  extern AVOutputFormat *first_oformat;
> > >  #endif
> > >  
> > > +/**
> > > + * If \p f is NULL returns the first registered input format,
> > > + * if \p is non-NULL returns the registered input format next after \p f,
> > > + * or NULL if \p f is the last one.
> > > + */
> > 
> > i must admit i really hate this \p sh*t but is "\p is" correct?
> 
> Doh! I hate when I read a patch so many times and still I miss obvious
> errors :-(.

looks ok 

> 
> As for the \p I have no problem at stripping them all, let's hear what
> Diego will say.

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090214/6befc135/attachment.pgp>



More information about the ffmpeg-devel mailing list