[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Reimar Döffinger]

On Sun, Feb 15, 2009 at 05:20:41PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 15, 2009 at 05:09:01PM +0100, Reimar D?ffinger wrote:
> > And to clarify: I meant that I do not know why they are user-settable in the first
> > place.
> 
> well the slice flags specify the limitations of the user app,
> if mplayers limitations between xvmc and normal vo differ this is
> mplayers problem.

Well, as long as that check (which fails hard) is there in FFmpeg it
is not just a limitation of the user app, and it wouldn't help a bit if
MPlayer's XvMC supported the format that not setting SLICE_FLAG_CODED_ORDER
would produce.
Btw. if those flags describe user limitations their description is
backwards, they describe how lavc behaves, not what kind of features the
user must support. It is also unclear how using SLICE_FLAG_ALLOW_FIELD
with actual decoding is supposed to behave, since draw_horiz_band does
not seem to provide anything to determine if it is the top or the bottom
field (or both) that is finished...

> you can just always set the slice flags if it works, it should be
> faster

SLICE_FLAG_CODED_ORDER doesn't work. SLICE_FLAG_ALLOW_FIELD works for
the samples I tried, but I don't think they are field coded.