[FFmpeg-devel] [PATCH] libavfilter-soc: misc fixes for vf_format.c:init()
Mon Feb 16 22:15:32 CET 2009
On date Monday 2009-02-16 18:04:15 +0100, Vitor Sessak encoded:
> Stefano Sabatini wrote:
> > Hi all,
> > summary:
> > * fail-if-invalid-format.patch
> > Make the init immediately fail if an unknown format or a too long
> > one has been introduced in the list.
> > This prevents unexpected behaviors, for example if the user simply
> > made a typo.
> > * format-introduce-len.patch
> > Introduce a len variable, improve readability and help the following
> > refactoring work.
> > * format-fix-off-by-one.patch
> > If the size of the read name is 32, the current code goes to write
> > on the byte just after the end of the "name" array.
> > * factorize-format.patch
> > Make the case "last name in the list" to be treated in the same loop
> > as the case "not last name in the list", improve overall design of
> > the function.
> > * format-reindent+cosm.patch
> > Reindent after the last commit + newline for pleasing your eyes.
> > * fix-messages.patch
> > Capitalize and add a missing '\n'.
> > * print-invalid-pixel-format.patch
> > Print in the error message the name of the unknown pixel format,
> > make the message more helpful.
> All fine for me. Since you are at it, I suggest also using a "#define
> FMT_NAME_MAXSIZE 32" instead of hardcoding it all over the file.
All applied, included a change implementing your last suggestion,
FFmpeg = Forgiving & Fantastic Maxi Powered Enhancing God
More information about the ffmpeg-devel