[FFmpeg-devel] [RFC] wma encoder regtest
Tue Feb 17 15:38:19 CET 2009
Michael Niedermayer wrote:
> On Tue, Feb 17, 2009 at 02:32:30PM +0100, Benjamin Larsson wrote:
>> I suggest we disable the wmaencoder regtest. Rounding the sine tables
>> and bypassing the fft didn't work on all platforms. IMO the decode test
>> of encoded data is enough.
>> And regardless of the result I wont spend any
>> more time in this matter.
> good i was alraedy confused by you continously posting patches that could
> not have worked
> if you want a fixed point FT write the 5 lines of c code that implements one
> and use a fixed point sin()
> using a float fft and float sin with funny rounding in the middle
Last patch did not use a fft at all. The permute and fft call was a nop.
Comparable to your suggestion of using memcpy instead. Feel free to fix
the regtest in whatever way you prefer.
More information about the ffmpeg-devel