[FFmpeg-devel] [PATCH] add forgotten check for frame_start() return value

Michael Niedermayer michaelni
Wed Feb 18 16:26:00 CET 2009

On Wed, Feb 18, 2009 at 04:19:51PM +0100, Reimar D?ffinger wrote:
> On Wed, Feb 18, 2009 at 04:00:02PM +0100, Michael Niedermayer wrote:
> > On Wed, Feb 18, 2009 at 11:25:27AM +0100, Reimar D?ffinger wrote:
> > > if get_buffer fails, the H.264 decoder may crash.
> > > This patch fixes this by adding an obviously forgotten return value
> > > check for frame_start:
> > 
> > why is the other frame_start setting first_field= 0 and yours not?
> Because setting first_field is not necessary to stop it crashing (thus
> even if it should be done it could be considered better to apply
> separately) and I do not want to make changes I neither understand
> nor know how to test.

if you consider this awnser enough then apply

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/967bb638/attachment.pgp>

More information about the ffmpeg-devel mailing list