[FFmpeg-devel] [PATCH] add forgotten check for frame_start() return value
Wed Feb 18 21:18:14 CET 2009
On Wed, Feb 18, 2009 at 04:42:34PM +0100, Reimar D?ffinger wrote:
> On Wed, Feb 18, 2009 at 04:26:00PM +0100, Michael Niedermayer wrote:
> > On Wed, Feb 18, 2009 at 04:19:51PM +0100, Reimar D?ffinger wrote:
> > > On Wed, Feb 18, 2009 at 04:00:02PM +0100, Michael Niedermayer wrote:
> > > > On Wed, Feb 18, 2009 at 11:25:27AM +0100, Reimar D?ffinger wrote:
> > > > > if get_buffer fails, the H.264 decoder may crash.
> > > > > This patch fixes this by adding an obviously forgotten return value
> > > > > check for frame_start:
> > > >
> > > > why is the other frame_start setting first_field= 0 and yours not?
> > >
> > > Because setting first_field is not necessary to stop it crashing (thus
> > > even if it should be done it could be considered better to apply
> > > separately) and I do not want to make changes I neither understand
> > > nor know how to test.
> > if you consider this awnser enough then apply
> Not really, but it is all I know.
> Or more precisely I know:
> 1) it prevents a crash, so it is better than the current code
why does frame_start() fail ?
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel