[FFmpeg-devel] [PATCH] Fix imlib2 vhook warnings
Wed Feb 18 23:14:44 CET 2009
On date Sunday 2009-02-15 17:49:21 +0100, Stefano Sabatini encoded:
> On date Sunday 2009-02-15 10:43:57 +0100, Stefano Sabatini encoded:
> > Hi all,
> > since VHOOK is going to be used anyway for some time bundled with the
> > next incoming release, maybe this makes sense, and it's better than to
> > keep them in my working copy anyway.
> > Most of the issues are missing consts, but there is also an uncatched
> > potential crash (apparently VHOOKs are never Released!!).
> I know Michael won't review these and with good reasons, so I'm going
> to wait some days for the others devs to review, then I'm going to
> apply them (VHOOK is currently no man's land, also the patches are
> mostly trivial) and take over the consequences of that action ;-)...
Hi, applied all but the one calling av_strdup(), since it has
consequences on the generated object code and I don't want to waste
too much time testing it, the code as it is looks wrong, it may crash
on Release but luckily that is never called anyway ;-)
FFmpeg = Faithful Fundamentalist Mortal Picky Ephemeral Gargoyle
More information about the ffmpeg-devel