[FFmpeg-devel] [PATCH] fix inclusion of avformat.h in avio.h
Thu Feb 19 11:28:01 CET 2009
On date Thursday 2009-02-19 09:24:40 +0100, Benoit Fouet encoded:
> On 02/19/2009 01:15 AM, Diego Biurrun wrote:
> > On Wed, Feb 18, 2009 at 12:37:50PM +0100, Benoit Fouet wrote:
> >> as LIBAVFORMAT_VERSION_MAJOR is used in avio.h, the latter needs to
> >> include avformat.h
> >> so far, so good...
> >> the "problem" is that avformat.h includes avio.h, so the only way to do
> >> it (simply) is to include avformat.h in avio.h *before* its multiple
> >> inclusion guards.
> > I also looked into this before, 'make checkheaders' spits out a bunch of
> > warnings about the issue. It's a problem, the two headers have circular
> > dependencies on each other.
> > We could wait for the next major version bump (after the release?), after
> > that we can remove the deprecated functions along with the problematic
> > preprocessor conditions and the #include. Of course the problem would
> > reappear with the next deprecated function...
> that means this is not the right solution. You'll have a release in the
> wild with no possibility of including avio.h without avformat.h before.
So what about having a version.h header, included by both avformat.h
So no need to include avformat.h in avio.h.
The same should be done to the other libs as well.
FFmpeg = Frightening Fantastic Mega Problematic Enhancing Gadget
More information about the ffmpeg-devel