[FFmpeg-devel] [PATCH] fix ffplay eof memleak (issue806)

[Michael Niedermayer]

On Sat, Feb 14, 2009 at 05:54:46PM +1100, Peter Ross wrote:
[...]
> Index: ffplay.c
> ===================================================================
> --- ffplay.c	(revision 17219)
> +++ ffplay.c	(working copy)
> @@ -2090,7 +2090,7 @@
>          }
>          ret = av_read_frame(ic, pkt);
>          if (ret < 0) {
> -            if (url_ferror(ic->pb) == 0) {
> +            if (ret != AVERROR_EOF && url_ferror(ic->pb) == 0) {
>                  SDL_Delay(100); /* wait for user event */
>                  continue;
>              } else

ive approved this, but this change is incorrect
the EOF case must not leave the loop but rather cause "url_feof(ic->pb) if"
above to trigger so that null packets are injected to force remaining video
frames out of the decoder

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090219/50657111/attachment.pgp>