[FFmpeg-devel] [PATCH] PB-frames support for i263

Michael Niedermayer michaelni
Fri Feb 20 13:09:08 CET 2009


On Fri, Feb 20, 2009 at 11:37:40AM +0200, Kostya wrote:
> On Thu, Feb 19, 2009 at 01:59:37PM +0100, Michael Niedermayer wrote:
> > On Thu, Feb 19, 2009 at 09:27:21AM +0200, Kostya wrote:
> [...] 
> > > Index: libavcodec/h263.c
> > > ===================================================================
> > > --- libavcodec/h263.c	(revision 16921)
> > > +++ libavcodec/h263.c	(working copy)
> > > @@ -6185,17 +6232,48 @@
> > >          return -1;      /* SAC: off */
> > >      }
> > >      s->obmc= get_bits1(&s->gb);
> > > -    if (get_bits1(&s->gb) != 0) {
> > > -        av_log(s->avctx, AV_LOG_ERROR, "PB frame mode no supported\n");
> > > -        return -1;      /* PB frame mode */
> > > +    s->pb_frame = get_bits1(&s->gb);
> > > +
> > > +    if(format == 7){
> > > +        format = get_bits(&s->gb, 3);
> > > +        if(format == 0 || format == 7){
> > > +            av_log(s->avctx, AV_LOG_ERROR, "Wrong Intel H263 format\n");
> > > +            return -1;
> > > +        }
> > > +        if(get_bits(&s->gb, 2))
> > > +            av_log(s->avctx, AV_LOG_ERROR, "Bad value for reserved field\n");
> > > +        s->loop_filter = get_bits1(&s->gb);
> > 
> > > +        if(get_bits1(&s->gb)){
> > > +            av_log(s->avctx, AV_LOG_ERROR, "Bad value for reserved field\n");
> > > +            return -1;
> > > +        }
> > 
> > hmm
> 
> oops
> 
> > > +        if(get_bits1(&s->gb))
> > > +            s->pb_frame = 2;
> > > +        if(get_bits(&s->gb, 5))
> > > +            av_log(s->avctx, AV_LOG_ERROR, "Bad value for reserved field\n");
> > > +        if(get_bits(&s->gb, 5) != 1)
> > > +            av_log(s->avctx, AV_LOG_ERROR, "Invalid marker\n");
> > >      }
> > > +    if(format == 6){
> > > +        int ar = get_bits(&s->gb, 4);
> > > +        skip_bits(&s->gb, 9); // display width
> > 
> > > +        if(!get_bits1(&s->gb))
> > > +            return -1;
> > 
> > hmpf
>  
>  
> oops2
> 
> This one should be right.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090220/7bb5ee41/attachment.pgp>



More information about the ffmpeg-devel mailing list