[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 5)
Fri Feb 20 18:31:21 CET 2009
Le 20 f?vr. 09 ? 18:22, Reimar D?ffinger a ?crit :
> Well, it is still reimplementing the FFmpeg function, even though for
> MPlayer it is not such an issue since IMGFMT_IS_.. is relatively easy
> to do, it may be more effort for other applications.
My point was that ff_is_hwaccel_pix_fmt() is too global outside FFmpeg
and a per-accelerator granularity would have been much better, IMHO.
> Also this approach doesn't seem like such a good idea to me,
> currently (and I do not
> see that changing) for MPlayer the hardware-acceleration format is
> implicitly specified by the -vo, adding another way to specify the
> thing can't do any good IMO - letting the hwaccel option select the vo
> seems like not such a good idea, since it is necessary to specify
> the vo
> to get things like denoising etc.. Hardware-decoding within FFmpeg
> to a
> uncompressed buffer is a different case of course.
Yes, my model was using an extra option for HW acceleration. -vo vaapi
-va vaapi seems duplicates but I still think they should be un-
related. e.g. what about conditions like -vo xv -va cuda or -vo x11 -
va omx or whatever? i.e. deriving the HW accelerator from the VO is
not a good idea IMO.
More information about the ffmpeg-devel