[FFmpeg-devel] [PATCH] Create a libavutil/pix_fmt.h with the pixel format stuff

Michael Niedermayer michaelni
Sat Feb 21 15:34:50 CET 2009


On Sat, Feb 21, 2009 at 03:28:18PM +0100, Stefano Sabatini wrote:
> On date Friday 2009-02-20 21:08:55 +0100, Michael Niedermayer encoded:
> > On Thu, Feb 19, 2009 at 11:29:45PM +0100, Stefano Sabatini wrote:
> > > On date Thursday 2009-02-19 22:00:59 +0100, Stefano Sabatini encoded:
> > > > > > First step creates a pix_fmt.h header (PixFmtInfo would then be added
> > > > > > to libavutil/pix_fmt.c)
> > > > > 
> > > > > PixFmtInfo as is is too bloated, it requires cleanup _first_
> > > > > also your patch misses installing the new header while a installed header
> > > > > depends on it
> > > > 
> > > > Yes.
> > > > 
> > > > Also I'm not sure if pixfmt.h (no underscore) is a better name.
> > > 
> > > Uh, patch missing...
> > 
> > probably ok
> 
> This changes the public interface,

how so?


> so I have to dump micro, right?

dump?
and you can bump micro as often as you like ...
no harm done by it ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090221/1a979b9b/attachment.pgp>



More information about the ffmpeg-devel mailing list