[FFmpeg-devel] [PATCH] fix playback of partial DV files
Sun Feb 22 10:44:08 CET 2009
On Sat, Feb 21, 2009 at 03:25:26PM -0800, Baptiste Coudurier wrote:
> Hi Reimar,
> Reimar D?ffinger wrote:
> > On Mon, Feb 09, 2009 at 10:48:20PM +0100, Reimar D?ffinger wrote:
> >> On Mon, Feb 09, 2009 at 01:24:23PM -0800, Baptiste Coudurier wrote:
> >>> You could avoid the seek by filling c->buf directly, would this be hard ?
> >> No, just didn't see it. I attached an updated version, I admit I did not
> >> test it, compilation is too slow on this PC.
> >>> Do you see a need in changing the test in the while loop like in the
> >>> probe function ?
> >> I don't think it matters much.
> >> But if you use
> >> (state & 0xffffff7f) != 0x1f07003f
> >> you can use just "unsigned" instead of uint32_t.
> >> A tiny bit faster and smaller code (since many architectures might be
> >> able to use instructions with immediates) might be
> >> uint32_t state;
> >> if ((state | 0x80) != 0x1f0700bf)
> >> I do think it is preferable to use the same variant everywhere.
> > Ping, what should be done about these patches?
> I'd say apply them, they should work, and won't cause much harm.
I applied mine, could you either apply yours yourself or send the
More information about the ffmpeg-devel