[FFmpeg-devel] [PATCH] Fix MPEG-TS seek and frame positions in general

[Baptiste Coudurier]

On 2/23/2009 1:01 PM, Ivan Schreter wrote:
> Ivan Schreter wrote:
>> Baptiste Coudurier wrote:
>>   
>>> Hi,
>>>
>>> Ivan Schreter wrote:
>>>   
>>>     
>>>> Ivan Schreter wrote:
>>>>     
>>>>       
>>>>> Ivan Schreter wrote:
>>>>>   
>>>>>       
>>>>>         
>>>>>> Ivan Schreter wrote:
>>>>>>   
>>>>>>     
>>>>>>         
>>>>>>           
>>>>>>> [...]
>>>>>>> Patch #2: let mpegts format decoder return correct packet positions by 
>>>>>>> keeping track of position of first TS packet of a PES packet in 
>>>>>>> MpegTSPESFilter.
>>>>>>>           
>>>>>>>             
>>> I believe AVPacket->pos should be set to the point where a byte seek can
>>> occur for formats allowing it, this can be really useful for application
>>> constructing indexes and/or using AVIndex.
>>>
>>> So in this case I believe AVPacket->pos should be set to the 0x47 byte
>>> containing the start of the PES packet containing the frame.
>>>
>>>   
>>>     
>> Um, this is the case with the patch...
>>
>> If I look in the ts file, the positions returned point exactly to 0x47 
>> byte. Did you see something different in your sample?
>>
>>   
> Ping Baptiste/Mans?

Yes, did you address my comment with stream->pos being -1 ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org