[FFmpeg-devel] [PATCH] fixes and optimization for ff_find_start_code ()
Thu Feb 26 17:34:27 CET 2009
On Thursday 26 February 2009 17:03:49 you wrote:
> this mixes cosmetic and functional changes and thus is unreviewable
Sorry, the attached patch is strictly functional changes.
> > + *state = 0xFFFFFFFF;
> this though looks very wrong
Currently ff_find_start_code() puts garbage in state when no start code could
be found. That garbage can be anything. This way the caller has a way to
actually know if a valid start code was found or not. I reviewed all users of
this function and there will be no problem with this. We can even remove code
here and here which tries to deal with exactly that problem. Or is there
something I am not seeing?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2759 bytes
Desc: not available
More information about the ffmpeg-devel