[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers

Michael Niedermayer michaelni
Fri Feb 27 13:33:45 CET 2009

On Fri, Feb 27, 2009 at 01:11:37PM +0100, Gwenole Beauchesne wrote:
> On Fri, 27 Feb 2009, Reimar D?ffinger wrote:
>> The purpose of get_buffer is to use a buffer provided by the application
>> and let the application do its own buffer management however it wants
>> to.
>> Now, the problem why you want to do it this way seems to be that the
>> application otherwise would need a callback to FFmpeg to allocate
>> hwaccel_data.
>> The question is, why is that needed? The reason seems to be
>> "struct vaapi_render_state_private" which the application can not
>> allocate itself.
> You can see that vaapi_render_state_private as vdpau_render_state. 
> Currently, the application allocates those. But Michael wanted lavc to 
> handle that itself, so I was only suggesting patches to achieve this. Since 
> this yields mess, in your opinion, it's probably not a good idea then. i.e. 
> let's just stick to the current approach: have the application allocate the 
> *_render_state structs.

I dont remember suggesting this...
what i suggested IIRC was that the struct could be stored in a struct not in
data that is uint8_t []
also what i suggested possibly not clear enough was that i would like to avoid
using VA/VDPAU structs or types in the public API of libavcodec.
The reason is this creates a terrible dependancy mess on the hw apis ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090227/65cad129/attachment.pgp>

More information about the ffmpeg-devel mailing list