[FFmpeg-devel] [PATCH] rtpdec.c: don't overwrite pkt->stream_index in finalize_packet()

Luca Abeni lucabe72
Sat Feb 28 19:54:37 CET 2009

Ronald S. Bultje wrote:
>>> On that line, I suppose attached patch fixes the same issue and is in
>>> fact much simpler.
>> I suspect this would break the timestamps for all the frames that are
>> not the first one in an RTP packet.
> The code is only executed if s->parse_packet is non-NULL, and for the
> first frame in a RTP packet finalize_packet() isn't called either if
> s->parse_packet is non-NULL. So either it breaks it consistently
> (which would suck less), or it isn't actually necessary. I don't know
> which one is true.

As I said, the fact that finalize_packet() is not called for the first 
packet is a bug that should be fixed... Your last patch makes the code 
more consistent by introducing the bug in the codepath that is 
currently correct, but I do not like this kind of consistency ;-)


More information about the ffmpeg-devel mailing list