[FFmpeg-devel] [PATCH] H.264: x264 SSE2 iDCT functions

Jason Garrett-Glaser darkshikari
Fri Jan 2 22:36:11 CET 2009

On Fri, Jan 2, 2009 at 4:14 PM, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hello,
> On Fri, Jan 2, 2009 at 9:37 PM, Jason Garrett-Glaser
> <darkshikari at gmail.com> wrote:
>> Patch attached.
>> +#if defined(CONFIG_GPL) && defined(HAVE_YASM)
>> +static void ff_h264_idct_dc_add8_mmx2(uint8_t *dst, int16_t *block, int stride)
>> +{
> This is just to avoid having unreferenced code, right? I assume you're
> not doing to license ff_h264_idct_dc_add8_mmx2 under GPL...

Yes, of course.  I can't license it under GPL, it's basically copied
from the original idct_dc.

Also, Michael, why isn't idct_add8 (the chroma 8-4x4idct function)
used at all?  Did you forget to insert it when you added
add16/add16_intra into h264.c?

Dark Shikari

More information about the ffmpeg-devel mailing list