[FFmpeg-devel] [PATCH] fixes in mpeg audio parsing
Sun Jan 4 17:36:46 CET 2009
On Fri, Nov 14, 2008 at 02:33:51AM +0200, Yoav Steinberg wrote:
> Michael Niedermayer wrote:
> > On Thu, Nov 13, 2008 at 09:10:41PM +0200, Yoav Steinberg wrote:
> >> Michael Niedermayer wrote:
> >>> On Thu, Nov 13, 2008 at 06:59:17PM +0200, Yoav Steinberg wrote:
> >>> [...]
> >>>>> One certainly could have concatenated 2 mp3 files with a id3v1 ending in
> >>>>> the middle it would be nice if the parser & decoder would skip/ignore this
> >>>>> trash in the middle.
> >>>>> To me it seem that it shouldnt be too hard to make the parser skip
> >>>>> this, unless a valid id3v1 tag can also be a valid mp3 frame.
> >>>> The current parser will, in most cases, skip id3v1 tags in the stream
> >>>> which is good. But in one case the parser does actually think the tag is
> >>>> part of a frame and does not skip it. This is when the tag was put
> >>>> inside (overwriting) a frame's data. This isn't strictly valid, but it
> >>>> turns out there are such files out there.
> >>> so, fix the parser
> >> I don't see how the parser can detect such a case. If the tag data is
> >> inside the frame's data the parser will see a valid frame.
> > now i do not know if such case exists (maybe you could upload a sample?)
> Not sure how you'd like to get the samples. I've put them on a web
> server, if that's good for you (I'll remove them in 24h):
> These are 3 such cases I've come across running on part of my sample
> base, it _might_ not be possible for me to find out how they were
> encoded, since they are part of a large collection gathered from many
> sources. I don't know if you're interested in "the chance" of finding
> such a file, I've tested 142 files from my collection and found these 3.
ok, so there are 3 samples that have some id3 like tag at the end.
but what was the problem with them, that this patch is supposed to fix?
are there artifacts i missed, there is surely no error or warning messages
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel