[FFmpeg-devel] [PATCH] Drop AVFrac at the next lavf major bump

[Stefano Sabatini]

Hi all, this is just to revive the old discussions about the removal
of AVFrac.

Related threads:
http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/60413
http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/38380

I picked up the Mans patch, with some little modifications to avoid to
break backward compatibility, yes it's done with ugly ifvers but I
don't think there are better ways... apart from bump major seems there
seems to be many important changes (metadata API) in these days.

I think the AVRational64 approach is correct, since it shouldn't lose
precision, unfortunately there is some regressions which I think are
due to some roundings, I still didn't investigate but I will do if you
like the approach.

Result of the regression tests:
--- /home/stefano/src/ffmpeg/tests/ffmpeg.regression.ref	2008-10-16 12:41:33.000000000 +0200
+++ tests/data/vsynth.regression	2009-01-05 00:51:14.000000000 +0100
@@ -197,7 +197,7 @@
 264248 ./tests/data/a-adpcm_yam.wav
 e92cec8c07913ffb91ad2b11f79cdc00 *./tests/data/adpcm_yam.vsynth.out.wav
 stddev:18312.78 PSNR: 11.06 bytes:  1056812/  1058444
-de1122d20d56c44cf49f028e25a67788 *./tests/data/a-adpcm_swf.flv
+eeb74cf29e037c28a71e22c2c936f8f0 *./tests/data/a-adpcm_swf.flv
 267073 ./tests/data/a-adpcm_swf.flv
 e48b800e2d9be6afcd430d4f08a34eb6 *./tests/data/adpcm_swf.vsynth.out.wav
 stddev:  934.28 PSNR: 36.91 bytes:  1056812/  1058444
@@ -205,11 +205,11 @@
 353368 ./tests/data/a-flac.flac
 95e54b261530a1bcf6de6fe3b21dc5f6 *./tests/data/flac.vsynth.out.wav
 stddev:    0.00 PSNR:999.99 bytes:  1058444/  1058444
-4435d87463cd6c5407bd88cca241ca56 *./tests/data/a-wmav1.asf
+dd86b460c78f66c13f795cbdcee35fe9 *./tests/data/a-wmav1.asf
 106004 ./tests/data/a-wmav1.asf
 stddev:12251.38 PSNR: 14.56 bytes:  1056812/  1058444
 stddev: 2105.96 PSNR: 29.85 bytes:  1048620/  1058444
-24ae726aef89e5d17e315c64182f4c61 *./tests/data/a-wmav2.asf
+144a8a9bcf4f09e7b46857547283b93b *./tests/data/a-wmav2.asf
 106044 ./tests/data/a-wmav2.asf
 stddev:12255.80 PSNR: 14.55 bytes:  1056812/  1058444
 stddev: 2099.27 PSNR: 29.88 bytes:  1048620/  1058444
@@ -237,11 +237,11 @@
 1058444 ./tests/data/a-pcm_s16le.wav
 95e54b261530a1bcf6de6fe3b21dc5f6 *./tests/data/pcm.vsynth.out.wav
 stddev:    0.00 PSNR:999.99 bytes:  1058444/  1058444
-5a2c3500cf180e8f5fa47f725d635767 *./tests/data/a-pcm_s16be.mkv
+1fc3faf36770173e1babe4584d39bd8b *./tests/data/a-pcm_s16be.mkv
 1066121 ./tests/data/a-pcm_s16be.mkv
 95e54b261530a1bcf6de6fe3b21dc5f6 *./tests/data/pcm.vsynth.out.wav
 stddev:    0.00 PSNR:999.99 bytes:  1058444/  1058444
-2cc0a1fb4553d29cccfa99d8f4f2d6e8 *./tests/data/a-pcm_s16le.mkv
+b3b693e4b24d3028ea24bfeae37a7e2b *./tests/data/a-pcm_s16le.mkv
 1066121 ./tests/data/a-pcm_s16le.mkv
 95e54b261530a1bcf6de6fe3b21dc5f6 *./tests/data/pcm.vsynth.out.wav
 stddev:    0.00 PSNR:999.99 bytes:  1058444/  1058444

BTW, currently ffmpeg will badly borke at the next major lavf bump,
since it uses the ifversioned
AVFormatParameters.{video|audio}_codec_id, and so libavformat/img2.c.

Regards.
-- 
FFmpeg = Foolish Foolish Most Patchable Erroneous Gorilla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-avrational64.patch
Type: text/x-diff
Size: 488 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090105/5f766a46/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: replace-avstream-pts.patch
Type: text/x-diff
Size: 3153 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090105/5f766a46/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: update-ffmpeg-pts.patch
Type: text/x-diff
Size: 1835 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090105/5f766a46/attachment-0002.patch>