[FFmpeg-devel] [RFC] asf metadata

Benoit Fouet benoit.fouet
Mon Jan 5 17:03:33 CET 2009


On 01/05/2009 02:57 AM, Ronald S. Bultje wrote:
> Hi,
>
> On Sun, Jan 4, 2009 at 2:07 PM, Benjamin Larsson <banan at ludd.ltu.se> wrote:
>   
>> @@ -146,9 +161,17 @@
>>      int64_t gsize;
>>      AVRational dar[128];
>>      uint32_t bitrate[128];
>> +    uint32_t wmaDrcPeakRef[128];
>> +    uint32_t wmaDrcPeakTarget[128];
>> +    uint32_t wmaDrcAvgRef[128];
>> +    uint32_t wmaDrcAvgTarget[128];
>>
>>      memset(dar, 0, sizeof(dar));
>>      memset(bitrate, 0, sizeof(bitrate));
>> +    memset(wmaDrcPeakRef, 0, sizeof(wmaDrcPeakRef));
>> +    memset(wmaDrcPeakTarget, 0, sizeof(wmaDrcPeakTarget));
>> +    memset(wmaDrcAvgRef, 0, sizeof(wmaDrcAvgRef));
>> +    memset(wmaDrcAvgTarget, 0, sizeof(wmaDrcAvgTarget));
>>
>>      get_guid(pb, &g);
>>      if (memcmp(&g, &asf_header, sizeof(GUID)))
>>     
>
> Isn't any local variable automatically zero'ed already?
>
>   

nope

Ben





More information about the ffmpeg-devel mailing list