[FFmpeg-devel] [PATCH] metadata compatibility layer (part2)

Michael Niedermayer michaelni
Wed Jan 7 21:35:45 CET 2009


On Wed, Jan 07, 2009 at 01:21:07AM +0100, Aurelien Jacobs wrote:
> Hi,
> 
> Hi attached patch is the second (and final) part of the metadata
> compatibility layer. It adds compatibility in the other way around.
> When a demuxer read metadata and stores it with av_metadata_set(),
> it automatically fill the old API metadata fields, so that a
> software using the old API is still able to get metadata from
> demuxers using the new API.
> 
> It is slightly ugly, especially the AVFormatContext pointer stored
> in the AVMetadata struct, but that's the cleanest way I found.
> As the struct is not exposed in public API and all of this is
> just a temporary transition code, I think it is acceptable.

I think this code is too ugly, i was already very unhappy about the
last of these compatibility patches but this one is just too much.
I do not want this or anything similar in a file i have to maintain.
Id much rather bump the major version several times.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090107/1939e990/attachment.pgp>



More information about the ffmpeg-devel mailing list