[FFmpeg-devel] [PATCH] metadata compatibility layer (part2)

Ronald S. Bultje rsbultje
Thu Jan 8 00:30:11 CET 2009


Hi,

On Wed, Jan 7, 2009 at 6:28 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Tue, Jan 6, 2009 at 7:21 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>> It is slightly ugly, especially the AVFormatContext pointer stored
>> in the AVMetadata struct, but that's the cleanest way I found.
>
> Why do you do it in av_metadata_set()? Why not in av_write_header(),
> where you actually have access to the AVFormatContext? That way, this
> ugly API isn't needed, and _all_ practical cases that you want to
> support set these metadata fields before calling av_write_header()
> anyway...

Hm, mixing up demuxers/muxers here, but same for
av_find_stream_info(), of course, or any other location called before
the first av_read_frame().

Ronald




More information about the ffmpeg-devel mailing list