[FFmpeg-devel] [PATCH] RTSP-MS 4/15: blocksize detection

Ronald S. Bultje rsbultje
Thu Jan 8 05:05:59 CET 2009

Hi Michael,

On Wed, Jan 7, 2009 at 9:29 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> why do you want to fail due to a unused variable?
> there should be a check for the actual packet or whatever being to
> large.

Well, that exists of course. We'll never read more than the buffer
size, and skip the rest until the next packet starts. Now, the problem
here is: what if the buffer wasn't large enough? We currently just
re-try to sync on a packet in tcp_read_packet() - i.e. essentially
skip it, or read as much as the buffer can hold as udp_read_packet().
Should we fail? Just continue and try to play what we can? In case of
the latter, which is what you (and Luca B.) appear to be leaning
towards, the attached patch would be enough and we can forget about
this whole Blocksize business.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtsp-ms-blocksize.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090107/9fc791c3/attachment.txt>

More information about the ffmpeg-devel mailing list