[FFmpeg-devel] [PATCH] RTSP-MS 4/15: blocksize detection

[Ronald S. Bultje]

Hi Luca

On Thu, Jan 8, 2009 at 5:24 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
> Ronald S. Bultje wrote:
>> Well, that exists of course. We'll never read more than the buffer
>> size, and skip the rest until the next packet starts. Now, the problem
>> here is: what if the buffer wasn't large enough? We currently just
>> re-try to sync on a packet in tcp_read_packet() - i.e. essentially
>> skip it, or read as much as the buffer can hold as udp_read_packet().
>> Should we fail? Just continue and try to play what we can? In case of
>> the latter, which is what you (and Luca B.) appear to be leaning
>> towards, the attached patch would be enough and we can forget about
>> this whole Blocksize business.
>
> I'd give a try to use blocksize the way the standard defines it, so
> something the client sets and error out if it doesn't come accordingly.

That's not what it says, right? It says that you can use any value
lower than requested by the client, "or override it with the
media-specific size if necessary". That second (overridden) value
could be any size, lower or higher (it is unspecified), and it would
still be compliant.

Ronald