[FFmpeg-devel] Possible bug in av_dup_packet()?

Michael Niedermayer michaelni
Fri Jan 9 16:27:11 CET 2009


On Fri, Jan 09, 2009 at 03:23:05PM +0100, Luca Abeni wrote:
> Hi,
>
> while working on different issues (support for v4l2 compressed
> devices), I noticed a strange behaviour in av_dup_packet():
> it seems to me that this function assumes that if
> pkt->destruct != av_destruct_packet then it is not necessary
> to call the destruct method (in fact, in this case the value
> of pkt->destruct is overwritten).
>
> I noticed this problem because v4l2.c sets destruct to a
> different method (used to release the v4l buffer), and this
> method is not called if av_dup_packet() is used.
>
> The attached patch fixes the issue for me, but I do not know
> if I am missing something...

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090109/6c1e3a3a/attachment.pgp>



More information about the ffmpeg-devel mailing list