[FFmpeg-devel] [PATCH]VDPAU patch for MPEG1/2 decoding, round 6

[Michael Niedermayer]

On Mon, Jan 12, 2009 at 01:18:11AM +0100, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached is a new version of the patch with PIX_FMT_VDPAU_MPEG1 and 
> PIX_FMT_VDPAU_MPEG2.
>
> Please comment, Carl Eugen

[...]

> @@ -1218,7 +1219,12 @@
>  
>      if(avctx->xvmc_acceleration)
>          return avctx->get_format(avctx,pixfmt_xvmc_mpg2_420);
> -    else{
> +    else if(avctx->codec->capabilities&CODEC_CAP_HWACCEL_VDPAU){

> +        if(avctx->sub_id == 1)

does a check for codec_id work too? if so i would prefer it


[...]
> @@ -2507,3 +2522,20 @@
>  };
>  
>  #endif
> +
> +#ifdef CONFIG_MPEG_VDPAU_DECODER
> +AVCodec mpeg_vdpau_decoder = {
> +    "mpegvideo_vdpau",
> +    CODEC_TYPE_VIDEO,
> +    CODEC_ID_MPEGVIDEO_VDPAU,

why actually is this not the normal CODEC_ID_MPEG1/2VIDEO ?
This would simplify some code ...
same for h.264, xvmc and vc1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090112/fc3d5ceb/attachment.pgp>