[FFmpeg-devel] [PATCH] change semantic of CONFIG_*
Wed Jan 14 00:37:01 CET 2009
M?ns Rullg?rd wrote:
> Aurelien Jacobs <aurel at gnuage.org> writes:
> > Mans Rullgad wrote:
> >> Aurelien Jacobs wrote:
> >> > Hi,
> >> >
> >> > Attached patch replaces each occurrence of #ifdef CONFIG_ by #if CONFIG_
> >> > and ensure CONFIG_* are always defined to 0/1.
> >> > I guess this one should please everyone.
> >> > Are you OK with this M?ns ?
> >> Yes, this is the right way to go, but please don't commit just yet.
> > OK. But I would like it to be committed shortly.
> > #ifdefs are introduced or modified quite often in the repository
> > and it's not exactly fun to keep such a patch up to date.
> >> > After this patch is applied, the plan is to
> >> > - change the semantic of HAVE_* and ARCH_* in the same way
> >> > - replace all the usage of ENABLE_ by CONFIG_
> >> > - remove all definitions of ENABLE_*
> >> If you don't mind, could you send incremental patches for these as well?
> >> Then I can test it on some more architectures. This is time-consuming,
> >> so I'd rather do it all in one go.
> > Here is a combo patch which changes the semantics of all the
> > CONFIG_*, HAVE_* and ARCH_*.
> > It don't change the ENABLE_* for now, but those will be trivial to
> > replace, and thus, won't need any extensive testing.
> > So feel free to test this patch on various arch and tell me when
> > I can commit :-)
> Tested on Alpha, ARM, PPC, SH4 (qemu), and x86-64. No change in
> regression test results (not all pass), so go ahead and commit.
Thanks for the extensive testing !
More information about the ffmpeg-devel