[FFmpeg-devel] [PATCH] ADTS AAC with ID3v2

Robert Swain robert.swain
Thu Jan 15 13:23:06 CET 2009


2009/1/14 Alex Converse <alex.converse at gmail.com>:
> On Wed, Jan 14, 2009 at 9:17 AM, Michael Niedermayer <michaelni at gmx.at>wrote:
>> On Wed, Jan 14, 2009 at 12:23:00AM -0500, Alex Converse wrote:
>> [...]
>> > @@ -487,7 +472,7 @@ static int mp3_read_header(AVFormatContext *s,
>> >      ret = get_buffer(s->pb, buf, ID3v2_HEADER_SIZE);
>> >      if (ret != ID3v2_HEADER_SIZE)
>> >          return -1;
>> > -    if (id3v2_match(buf)) {
>> > +    if (ff_id3v2_match(buf)) {
>> >          /* parse ID3v2 header */
>> >          len = ((buf[6] & 0x7f) << 21) |
>> >              ((buf[7] & 0x7f) << 14) |
>>
>> the split out of (ff_)id3v2_match is ok but should be a seperate patch
>> and commit
>>
>
> Attached is the split, fixed and separated.

Your patch contains trailing whitespace. Your earlier ADTS patch did
too but I forgot to mention it.

This part applied with trailing whitespace removed.

Regards,
Rob




More information about the ffmpeg-devel mailing list