[FFmpeg-devel] [PATCH] remove CONFIG_AUDIO_NONSHORT

Michael Niedermayer michaelni
Thu Jan 15 15:15:34 CET 2009


On Thu, Jan 15, 2009 at 12:30:27AM +0100, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> 
> > On Wed, Jan 14, 2009 at 11:15:49PM +0100, Aurelien Jacobs wrote:
> > > Hi,
> > > 
> > > CONFIG_AUDIO_NONSHORT is never set anywhere (and IIRC it never was).
> > > Do the related code have any use for anyone ?
> > > Maybe we could simply drop this useless code like with attached patch.
> > > Anyway, it's very simple and could be added back latter is someone
> > > feel the need.
> > 
> > CONFIG_AUDIO_NONSHORT should be considered to be 1
> 
> I'm fine with this too. Just note that it was never enabled before,

so a benchmark would be usefull ...


> and that enabling it changes regtest results.
> See attached patch.

[...]
> -stddev: 4394.71 PSNR: 23.46 bytes:  1053352/  1058444
> +stddev: 4785.84 PSNR: 22.72 bytes:  1053352/  1058444

why does this become worse?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090115/d2798d8c/attachment.pgp>



More information about the ffmpeg-devel mailing list