[FFmpeg-devel] [RFC] avfilter_request_frame() crash

Michael Niedermayer michaelni
Thu Jan 15 23:12:12 CET 2009


On Thu, Jan 15, 2009 at 09:37:39PM +0100, Vitor Sessak wrote:
> Stefano Sabatini wrote:
> > Hi all,
> > 
> > when calling avfilter_request_frame() on a link with no source it
> > crashes, for example with:
> > 
> > ffplay -f video4linux -s 320x240 /dev/video -vfilters "[in] setpts=PTS-STARTPTS, hflip, setpts=PTS-STARTPTS [foo]"
> > 
> > Should we:
> > 1) add a check in avfilter_request_frame(), so that it will return -1
> >    if the link source is NULL
> > 2) ensure that no dangling links exist before to start to extract
> >    filters from the filterchain
> > 3) both 1) and 2)
> 
> I'd say (2) or (3), I don't think "[in] setpts=PTS-STARTPTS, hflip, 
> setpts=PTS-STARTPTS [foo]" should be considered a valid description of a 
> filter chain.

agree

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090115/b940edec/attachment.pgp>



More information about the ffmpeg-devel mailing list