[FFmpeg-devel] [PATCH] aviobuf.c cleanup

Michael Niedermayer michaelni
Fri Jan 16 14:12:04 CET 2009

On Fri, Jan 16, 2009 at 11:23:01AM +0100, Reimar D?ffinger wrote:
> Hello,
> I just noticed I had these changes lying around.
> There is some nonsense in that file like a "return -1234;".
> Also this check:
>   if(sizeof(DynBuffer) + io_buffer_size < io_buffer_size)
>             return -1;
> Causes a warning for comparing signed and unsigned and I am not
> completely sure it is actually working as expected.
> I don't want to make a lot of effort, so just cherry-pick the parts
> I can apply or that you don't want, I'll apply them separately or remove them
> and send the remainder as a new patch.

all fine

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090116/f4f0bf0f/attachment.pgp>

More information about the ffmpeg-devel mailing list