[FFmpeg-devel] flac decoding

Diego Biurrun diego
Fri Jan 23 09:34:09 CET 2009

On Thu, Jan 22, 2009 at 11:13:28PM -0500, Justin Ruggles wrote:
> 1. rename flac.c to flacdec.c

If it only contains decoding code, go right ahead.

> 3. clean up debugging statements
> flac.c is littered with debugging code. Some of it is commented-out,
> some of it is not. Some of it is outdated. Should the debugging
> printouts be left in there and the commented ones enabled? comment-out
> the enabled ones? or take them out altogether. I have not found them
> useful, but then again they sort of do the same as "flac -a" and it
> might be useful at some point to compare the values in the two outputs.

I say remove them.  They will be easy to restore in case of need.

> 4. remove unused code
> There are some chunks of code which are disabled with ifdefs or
> commented out. They seem to mostly be alternative implementations...
> What is being used seems to work ok. I see no need to keep this old code
> around in HEAD.

I vote for removal.

> 5. coding style clean up & some indentation cosmetics
> The coding style in flac.c is very inconsistent.

I think as long as you keep this properly separated from other types
of changes, you can always directly commit such things without asking.
Oh, and I suggest going for K&R style while you're at it...

> Suggestions welcome!

Take over maintainership.


More information about the ffmpeg-devel mailing list