[FFmpeg-devel] [PATCH] ADTS AAC with ID3v2

David DeHaven dave
Fri Jan 23 23:38:36 CET 2009

> The only thing I have an issue with is the FIXME comment.  I don't see
> why we should ever support actually reading the ID3 from FLAC files.
> FLAC has a proper way to store metadata.

I'm in complete agreement, however, if people (or music library apps)  
did things properly to begin with the patch would be completely  
unnecessary :)

IMHO, the ID3 parsing should be done outside of the container  
processing anyways instead of hacking all the probe calls to deal with  
it. But since libavformat seems to only support the concept of one  
container per file/stream, I don't see how that can be done cleanly  
unless an explicit test for ID3 tags is done prior to format probing.


More information about the ffmpeg-devel mailing list