[FFmpeg-devel] [PATCH] Make av_base64_decode() fail if the input sequence is invalid

Michael Niedermayer michaelni
Sun Jan 25 00:29:52 CET 2009

On Sat, Jan 24, 2009 at 11:18:05PM +0100, Stefano Sabatini wrote:
> Hi,
> currently av_base64_decode() doesn't fail with invalid data of the
> kind "M", "M==M==", "M===".
> Though I'm not sure the patch implements a good idea, maybe the
> decoder should be tolerant and accept not perfectly legal but on the
> other end meaningful inputs (for example "MQ" although not legal is
> perfectly equivalent for the decoder to "MQ=="), anyway in this case
> we cannot use the function av_base64_decode() to validate data.
> An idea could be to add a flag like this:
> int av_base64_decode2(uint8_t * out, const char *in, int out_length, int validate)
> but maybe this is overkill.
> Opinions are welcome.

Who wants and needs this where for what?
if you cant awnser this, why would we want to implement it? just for
implementations sake?
maybe it is very usefull for something, i dont know but you arent telling

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090125/a16584e4/attachment.pgp>

More information about the ffmpeg-devel mailing list