[FFmpeg-devel] [PATCH] ADTS AAC with ID3v2
Sun Jan 25 01:18:35 CET 2009
Justin Ruggles wrote:
> David DeHaven wrote:
>>> The only thing I have an issue with is the FIXME comment. I don't see
>>> why we should ever support actually reading the ID3 from FLAC files.
>>> FLAC has a proper way to store metadata.
>> I'm in complete agreement, however, if people (or music library apps)
>> did things properly to begin with the patch would be completely
>> unnecessary :)
>> IMHO, the ID3 parsing should be done outside of the container
>> processing anyways instead of hacking all the probe calls to deal with
>> it. But since libavformat seems to only support the concept of one
>> container per file/stream, I don't see how that can be done cleanly
>> unless an explicit test for ID3 tags is done prior to format probing.
> I agree with the patch overall, and I think that supporting these broken
> files is fine to the point of them working, but I think that any ID3
> stuck onto a FLAC file should only ever just be be skipped. That is
> also the behavior of the official FLAC reference decoder. A FIXME
> comment makes it look like we're not fully supporting something that we
> should be. That's all. :)
patch applied without the FIXME comment. if others disagree with me, it
can be added later.
More information about the ffmpeg-devel