[FFmpeg-devel] [RFC] use AV_WL32/AV_WB32 in put_bits

Reimar Döffinger Reimar.Doeffinger
Sun Jan 25 19:15:40 CET 2009


On Sun, Jan 25, 2009 at 06:54:49PM +0100, Michael Niedermayer wrote:
> On Sun, Jan 25, 2009 at 11:49:15AM +0100, Reimar D?ffinger wrote:
> > I do not know if this was maybe intentional, but it seems to me put_bits
> 
> i think the code predates AV_WL32() and likely was just missed
> so patch ok

Applied.

> > Maybe it could be simplified even more, since the else part is the same
> > as AV_W?32, too, when HAVE_FAST_UNALIGNED is set.
> 
> yes indeed, the whole if/else could be replaced by a single AV_W...
> this should be benchmarked though

That's why I did not propose it, I don't have the hardware to test this
(or more precisely, I could not yet compile FFmpeg for it).

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list