[FFmpeg-devel] [PATCH] Install preset files from ffpresets/ to ${prefix}/share/ffmpeg

[Michael Niedermayer]

On Sun, Jan 25, 2009 at 10:25:45PM +0000, Robert Swain wrote:
> 2009/1/24 Stefano Sabatini <stefano.sabatini-lala at poste.it>:
> > On date Saturday 2009-01-24 19:11:16 +0000, Robert Swain encoded:
> >> 2009/1/24 Diego Biurrun <diego at biurrun.de>:
> >> > On Sat, Jan 24, 2009 at 05:22:14PM +0000, Robert Swain wrote:
> >> >>
> >> >> See attached.
> >> >
> >> > Patch is OK from my side now, but I think you still need to get things
> >> > figured out with Stephano...
> >>
> >> It's a dirty hack, but we could check the prefix and if not equal to
> >> /usr or /usr/local we could install to ~/.ffmpeg/. I don't like it but
> >> it wouldn't be too bad I guess.
> >
> > I don't think this is a good idea, programs shouldn't mess with the
> > user's home unless explicitely told so.
> >
> >> It wouldn't really be too bad to install them anyway. They just
> >> won't be used until something is done about the use issue and the
> >> -vpre option does take a path to a file as well so it's not
> >> completely in vain.
> >
> > I agree, I think it's safe to apply your patch, then we'll add datadir
> > presets support when we'll address the datadir export issue.
> 
> Now M?ns has applied a patch to add datadir and export it to
> config.mak and config.h, how about these patches?
> 
> install_presets - Add (un)installation targets to the top Makefile to
> install the presets appropriately.
> use_presets - Alter opt_preset() in ffmpeg.c to use FFMPEG_DATADIR
> rather than /usr and /usr/local.

ffmpeg.c changes looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090125/a362fe48/attachment.pgp>