[FFmpeg-devel] [PATCH] cleanup #includes in libavutil/common.h

Måns Rullgård mans
Mon Jan 26 00:15:19 CET 2009

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Jan 25, 2009 at 10:19:24PM +0100, Diego Biurrun wrote:
>> libavutil/common.h conditionally #includes a bunch of system headers.
>> This seems to be unnecessary.  Here is a patch to get rid of this and
>> collect the #includes together.
> i dont know if this has sideeffects, so no approval nor rejection from
> me

All those headers are standard C headers, so unconditionally including
them should be harmless.  It could be argued, of course, that someone
including an FFmpeg header does not expect random system headers to be
pulled in as well.  However, in this case I think the improved
readability of our header outweighs any hypothetical problems one
might imagine.

In other words, go for it.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list