[FFmpeg-devel] [PATCH] remove unused and broken test program in libavutil/base64.c
Tue Jan 27 03:01:01 CET 2009
On Mon, Jan 26, 2009 at 11:28:18PM +0100, Stefano Sabatini wrote:
> On date Sunday 2009-01-25 10:42:53 +0100, Diego Biurrun encoded:
> > On Sat, Jan 24, 2009 at 09:48:16PM +0100, Stefano Sabatini wrote:
> > > On date Friday 2009-01-23 09:53:41 +0100, Diego Biurrun encoded:
> > > > On Thu, Jan 22, 2009 at 12:09:19AM +0100, Stefano Sabatini wrote:
> > > > > On date Thursday 2009-01-22 00:04:13 +0100, Diego Biurrun encoded:
> > > > > > I found some more cruft in the attic: a forgotten test program in
> > > > > > libavutil/base64.c. It never compiled, not even the day it was
> > > > > > committed, since it calls av_base64_encode() with a wrong number
> > > > > > of parameters.
> > > > > >
> > > > > > OK to remove?
> > > > >
> > > > > Why not to simply fix it?
> > > >
> > > > The question is whether it is worth the trouble. Given that it is
> > > > proven that nobody ever used this program, I believe it to be
> > > > doubtful that anybody will in the future.
> > > >
> > > > Of course you can have a stab at fixing it...
> > >
> > > It turned out in a semi-complete rewrite of the test program, anyway I
> > > don't feel like to send a patch and discuss every single change, if
> > > it's possible to simply replace the new code I'll happily do it.
you know likely (after actually thinking about it at least)
that diffing old code against rewritten codeis not that usefull
for the purpose of reading/reviewing
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel