[FFmpeg-devel] [PATCH] [ISSUE 793] Fix mp3 identification regressions

Alex Converse alex.converse
Thu Jan 29 18:31:52 CET 2009

On Thu, Jan 29, 2009 at 12:28 PM, Alex Converse <alex.converse at gmail.com>wrote:

> Right now MP3 files with ID3v2 tags bigger than 2MB no longer identify as
> MP3. This patch makes the mp3 probe return 1 on files with id3v2 tags where
> mp3 was not identified to make these files identiy as MP3 on the last probe
> pass. A more elegant solution would be for the probes to be able to request
> seeking, however it seems that that would piss all over the API. I know
> Michael had suggested a return value to request more data in general but in
> theory ID3v2 can grow over 256 MB and I'm nto sure we'd want to sent that
> much information to the probe.

I suppose it might be helpful if I actually attach the patch.

> Regards,
> Alex Converse
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mp3_probe_score.diff
Type: text/x-diff
Size: 421 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090129/437bf01a/attachment.diff>

More information about the ffmpeg-devel mailing list