[FFmpeg-devel] [PATCH] Re: FLV1 codec; video bitrate not set

[Stefan de Konink]

Michael Niedermayer wrote:
>> +            else if(!strcmp(key, "videodatarate") && vcodec && 0
>> <=  (int)num_val)
> this should be checking 0 <= (int)(num_val * 1024.0) or something
> more  picky

What is the reasoning behind this? Do you want an explicit check for 
'sensible' bitrates? I don't see the point how: (0 < numval) != (0 < 
(numval * 1024.0))

I attached your suggestion.

> likely missing regression test update
> 
...
> 
> same

I ran regression test, and attached the output. I want to make it 
*extremely* clear that this patch does still result in a wrong (audio 
only) bitrate for videos where no meta information is available.


Stefan
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg-flv1-bitrate-4.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090130/4643665f/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg-flv1-regression.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090130/4643665f/attachment.asc>